Tristan Stenner

Results 198 comments of Tristan Stenner

Added data for the Matlab string chunk reader

> Can you summarize again why chunk3 reading is slow? The use of varlength ints (`lenlenght=f.read(1); len=f.read(lenlength);value=f.read(len);`; for timestamps `if(f.read(1) ts=f.read(8);`) means that the data has to be read in...

> the only chance a change to the file format will be accepted upstream is if all the major tools that use XDF are compatible with both formats in a...

> in chunk7, you need to supply either all timestamps (for each sample), or none As in chunk7, timestamps can be left out (i.e. all 8 bytes are 0). With...

> Practically speaking, if a device pushes out 1000 samples every second in a package, you could timestamp the first sample and have 999 zeros for the other samples. Correct?...

The channel count for lsl streams is already limited to 31 bits, so more wouldn't make sense for it to be larger in the xdf file. I could bump the...

I only have a shallow clone locally, but I'll hopefully get around to it in a few days. Meanwhile, I'll push PRs for Tim's latest commits and some of my...

> Unfortunately we haven't had time to dive in and provide the detailed feedback it deserves. Even though I also don't have the time for an extensive review, I'd like...

> I dont understand why there is not only lsl_push_sample which maps its input data to the type defined by the channel_format defined for the corresponding streaminfo. The push functions...

Just to clarify: the different functions are there to let the compiler prevent you from giving the wrong data type to a single `push_sample(void*)` function. The push (and pull) functions...