Surya Seetharaman
Surya Seetharaman
unrelated flake: ``` Summarizing 1 Failure: [FAIL] External Gateway With Admin Policy Based External Route CRs e2e multiple external gateway validation Should validate ICMP connectivity to multiple external gateways for...
unrelated failures happening in v6 lane: https://github.com/ovn-org/ovn-kubernetes/actions/runs/9518141867/job/26239613328?pr=4333 https://github.com/ovn-org/ovn-kubernetes/actions/runs/9518141867/job/26239615805?pr=4333
latest set was simply a rebase after flavio lgtm-ed it no new changes.
@pperiyasamy would you like to rebase this one? then I can shell out some review time here
OH I see if there are secondary IPs only on some nodes the other nodes are printing these logs that cause noise?
Is there a reason why we don't want to use LB Templates?
haven't forgotten this one, addressing comments :)
al'right I finally updated it @npinaeva : I think I fixed all your comments, if not lmk (sorry for the delay in coming here to re-push)
> I still find it difficult to understand 500 line long tests, hopefully we will split and simplify it in the future. the unit tests have been written in steps,...
ah oops need to fix the UTs..