corebos
corebos copied to clipboard
tsolucio
Toast UI listview is slow
I'm a bit confused @joebordes and @denaldhushi: is it slow or not? Denald seemed to think it was not that bad. How do you feel @joebordes?
first I would like to attend this issue, as that will affect performance while keeping consistency and making the code easier to maintain. I am a bit worried about implementing the list view logic again when we have invested so many hours in the version we have now.
then I would like to see some numbers. the speed may be my impression from the first validation I did, but the correct thing to do is to measure it: put a time measurement in the current list view code, from the start of the request to the sending of the result in both versions of the list view and get some numbers to be able to compare.
That is a good idea. I can't follow the link since I think it links to a card that has in the meantime been converted to an issue. As far as the implementing of new code is concerned: I believe we're long overdue to move forward on the UI. We should, however, place great effort in testing. I'm thinking about writing e2e tests with puppeteer, but we'd need some complex scenario's to write the tests to.
try this: click on the link, then click on reload, which should take you to this issue:
Reduce redundant code? This section of code seems repeated in other parts of the application.
Can we move that to a common function to avoid repeating the logic?
Ah it's not an issue, it's a card but now I know which one you mean. I think it's best if Denald tried a stab at that first