Thomas Mäder
Thomas Mäder
@tortmayr here's a video showing the problem: https://github.com/eclipse-theia/theia/assets/13163770/c9b7f66c-c9ac-40e1-8ff7-c9a6caaf9da6
The other problem seem fixed with this PR.
@rschnekenbu "secondary window" has a technical meaning in Theia. From the the context, I suspect you mean a "new Theia window"?
@rschnekenbu it's not clear to me what is actually happening. Do you have steps to reproduce?
Because if I type a https link in an editor (https://github.com) and ctrl-click it, opens in the browser.
I'm just not very sure this is a good idea: I know VS Code does it [here](https://github.com/microsoft/vscode/blob/1e38af34241f3909b7687d98a90cc7aeda31b7b3/src/vs/code/electron-main/app.ts#L427), but on the other hand, the electron security doc explicitly [warns against it](https://www.electronjs.org/docs/latest/tutorial/security#15-do-not-use-shellopenexternal-with-untrusted-content)....
This seems fixed in 1.48.0. Please let us know if it's still a problem for you.
It seems the remaining problem is related to how `msgpackr` treats array buffers. Consider this script: ``` const { Packr } = require ('msgpackr'); const inst= new Packr({ moreTypes: true,...
I have filed https://github.com/kriszyp/msgpackr/issues/135
Let's wait an see how they react to the issue.