Thomas Mäder

Results 214 comments of Thomas Mäder

That is entirely possible. Any reason why we're _not_ including all the built-ins from VS Code?

Even with those extensions installed, The sign-in fails with `Sign in failed: Error: Invalid scheme 'theia'`.

With the gitlens example from the testing instructions in the linked PR, I don't even get the "Connect to Github" link anymore. Reopening.

This is weird: when I log out of Github in VS Code, I get the "Connect to Github" link again, but when I click it, nothing happens in the UI:...

Turns out TheiaIDE just does not contain `github-authentication`. The Timeout is a false positive in `plugin-authentication-service.ts#tryActivateProvider`: we're racing success against timeout, but the timeout never is cancelled.

It seems I have a Github session in my Windows Credentials Manager. There is a problem in `authentication-ext.ts#registerAuthenticationProvider`: when a new registration provider is registered, we add a listener that...

Hmh...I'm not sure using the UrlHandlerFlow is a good idea anyway: it requires having the github app client secret available to the VS Code app, which is not recommended practice.

So even with the scheme changed to `vscode`, this does not work, since we obviously don't have access to the vscode github app client secret. Not sure how to implement...