Thomas Mäder

Results 214 comments of Thomas Mäder

Doing the same workflow on a mac works. The structure of the html looks very different in both cases: the "dirty-diff-glyph" div is missing from the line where the change...

> Perhaps not surprisingly, given that https://github.com/eclipse-theia/theia/pull/13217 was merged earlier today... Sorry about that. Let me know if you have questions about the update.

When I hover over the little red triangle that signifies "removed line", I can get the decorations to keep flickering between the red bar and the triangle icon. Maybe there...

@pisv I'll have time to come back to this one probably early next week.

> > Thanks for this very useful PR. > > Thanks for reviewing this PR. > > > The main issue I have is the direct use of monaco API...

@pisv I resolved all the comments that I don't think need further action.

Hi @pisv , except https://github.com/eclipse-theia/theia/pull/13104#discussion_r1497314715 I'm fine with this PR.

@pisv very cool, thanks. Rest assured that your efforts are much appreciated.

Sounds good, I'll have a look.

This looks a lot like something we're hitting in https://github.com/eclipse-theia/theia/issues/11642: when trying to close the second browser windows, we get the string "IllegalAccess" written to dev-tools javascript console with no...