Thomas Mäder

Results 214 comments of Thomas Mäder

The problem with the PeekView not being resizable is a problem in the VS Code code: in `sash.ts` on line 182, the code now reads: ``` return this.disposables.add(new DomEmitter(getWindow(this.el), 'mousemove')).event;...

The relevant PR in VS Code is https://github.com/microsoft/vscode/pull/195778

The mitigation of prototype pollution does not work anyway: the attack vector we're trying to prevent are workspace settings. However, settings files are processed in the front-end (preference-provider.ts, etc.) and...

@tortmayr I replaced the code that uses `Object.create(null)` with `Object.create({})` but the settings still don't show. That said, IMO, the assumption that I get a fully functional object from `configuration.inspect()`...

I guess the problem is ultimately that our code in `PreferenceRegistryExtImpl` uses the `Configuration` class form monaco: this class ultimately calls `toValuesTree()` from `configuratoin.ts`, which creates objects using `Object.create(null)`.

In the end, the answer why this works in VS Code is surprisingly simple: in `extHostConfiguration.ts`, the configuration object returned from `getConfiguration()` does a `deepClone` of all values in it's...

@kenneth-marut-work the title says "draft", but it's a regular non-draft PR. What's the truth?

@pisv what am I missing here? Here's what I do: 1. I changed the electron example to use the VS Code git extension because of https://github.com/eclipse-theia/theia/issues/12651 2. I open Theia...

Here's what I do after building the merge of your branch into master (as per "command line instructions") with the git/git base extensions enabled in the electron app. https://github.com/eclipse-theia/theia/assets/13163770/ce937f02-5140-48e0-8b8e-ba5534256ace In...

Maybe a Mac/Windows problem?