grpcbox-stream: Fix to support multiple simultaneous unary/strem calls

[vasu-dasari]

grpcbox-stream: Fix to support multiple simultaneous unary/strem calls

This commit addresses stress-test failure mentioned in https://github.com/tsloughter/grpcbox/pull/29

Added two new APIs: add_channel(Name, Endpoints, Options) delete_channel(Pid)

This would give ability to user to add and delete channels on the fly.

Also modified stress_test test case to use this logic. With out this change, stress test fails around 10 simultaneous connections. With this change I can see around 90 simultaneous connections.

[tsloughter]

Hey, sorry I hadn't gotten to this yet. I'll be taking some time this week to work on grpcbox, so will get to it sometime in the next couple days.

[tsloughter]

So the solution might be to have a configuration setting for how many connections to open per subchannel. A single connection can handle multiple concurrent streams but maybe you were hitting a limit on that concurrency and the need to increase the connections. But it could also be a chatterbox issue slowing down stream concurrency within a channel, so I also need to check that now.

[belltoy]

So the solution might be to have a configuration setting for how many connections to open per subchannel.

+1 any progress?

[vasu-dasari]

Hi @tsloughter,

Sorry did not see your comments. The problem with having an environmental variable to specify number of connections is a subjective one. We might hit a snag at some point. But with this patch, if the user knows by design how the connections are being established then it is better to give control to the application with channel management. In the patch there is a ct test to demonstrate the problem and working solution.