grpcbox icon indicating copy to clipboard operation
grpcbox copied to clipboard

grpcbox is is inconsistent with chatterbox/h2_client

Open carolcarolus opened this issue 5 years ago • 1 comments

Hi,

I noticed that grpcbox uses functions that do not exist. For example, grpcbox_subchannel.erl(line 96) uses: case h2_client:start_link(Transport, Host, Port, options(Transport, SSLOptions), #{stream_callback_mod => grpcbox_client_stream}) of There is no five argument function in chatterbox application.

Unfortunately it is required to create a new stream.

I am using the latest versions of grpcbox and chatterbox.

carolcarolus avatar Sep 09 '19 08:09 carolcarolus

@carolcarolus I have a fork of chatterbox that grpcbox is using. I have not merged it into chatterbox because, even though I maintain chatterbox now, I have not had anyone to help with reviews. I hope that changes now and we will see updates to chatterbox soon and remove the need for my fork.

tsloughter avatar Oct 06 '19 18:10 tsloughter