hobo icon indicating copy to clipboard operation
hobo copied to clipboard

Pull request for label changes

Open betelgeuse opened this issue 15 years ago • 7 comments

These were never pulled giving me a chance to try the new github pull request interface.

betelgeuse avatar Aug 31 '10 18:08 betelgeuse

I like this new pull request interface. I've verified 1,2,3&5 on the system tests. I'm worried about #4 breaking CSS for people, even though it's obviously the right direction to go. I wouldn't mind putting it into 1.1 if we could bundle it up with a few other similar fixups.

With this new github interface, will Matt & Tom see this comment? If so, I'd like an ack from one of them before pushing the 4 I've tested.

As for #6, I'd like an ack from ddnexus.

bryanlarsen avatar Sep 16 '10 18:09 bryanlarsen

Hmm, it appears the order has changed. afed62e, 978d4ff, 2288c04 and b509f1d have all been pushed into master but do not appear to be in Hobo 1.3. It's certainly possible that all 4 are not relevant for rails3.

The biggest change here is 289d4da. It's the right thing to do, but it will break somebody's CSS, so it cannot go into 1.0, but it should go into 1.1 and 1.3.

bryanlarsen avatar Feb 22 '11 15:02 bryanlarsen

Could you rebase please ?

lyrixx avatar Mar 07 '17 16:03 lyrixx

This is currently the oldest open PR on github... https://github.com/pulls?q=is%3Aopen+is%3Apr+sort%3Acreated-asc

rjmunro avatar Sep 29 '17 11:09 rjmunro

So any progress on this?

BoD avatar Mar 19 '21 09:03 BoD

Can we get this merged yet?

patrickklaeren avatar Jun 26 '21 21:06 patrickklaeren

This is currently the oldest open PR on github... https://github.com/pulls?q=is%3Aopen+is%3Apr+sort%3Acreated-asc

Still is even in 2023 and most likely will stay that way indefinitely

PythonCoderAS avatar Jan 20 '23 16:01 PythonCoderAS