Potential small bug in shapelets.py?

[GillesVandewiele]

I was browsing through the code and stumbled on this line: https://github.com/tslearn-team/tslearn/blob/7ead159338c91112341cdb2e4f8d2d59c75129a8/tslearn/shapelets.py#L402

Shouldn't this become self.max_size? Is there a unit test in place already that specifically tests for the behaviour of self.max_size (i.e. a test set with longer time series than the train set?).

There's also a small style issue with 1 line in the docs: https://github.com/tslearn-team/tslearn/blob/master/tslearn/shapelets.py#L297

I can fix these things (but perhaps confirm if this indeed needs to become self.max_size @rtavenar)

EDIT: I was confusing time series sizes and shapelet sizes... Nevertheless, I could still quickly fix that 1 style issue and check if there is a unit test present?

[rtavenar]

Hi @GillesVandewiele

I'm pretty busy until the end of this week. Will try to catch up early next week. If I don't, do not hesitate to ping me.

[rtavenar]

EDIT: I was confusing time series sizes and shapelet sizes... Nevertheless, I could still quickly fix that 1 style issue and check if there is a unit test present?

Yep, definitely!