tskit icon indicating copy to clipboard operation
tskit copied to clipboard

Remove legacy h5py based formats

Open benjeffery opened this issue 2 years ago • 5 comments

Opening this up for discussion.

As mentioned by @jeromekelleher at https://github.com/tskit-dev/tskit/pull/2811#issuecomment-1663778875 it has been a long time since these legacy formats were used. When dropping them we should add a note in the docs to specify the version of tskit to use to upgrade the file.

benjeffery avatar Aug 03 '23 11:08 benjeffery

Agree. We should add a stable hyperlink on the tskit docs (Legacy HDF5 file formats) which we provide a link to in the error message also, so people know where to look when the file doesn't load.

jeromekelleher avatar Aug 03 '23 11:08 jeromekelleher

I think we should do this ASAP. Definitely want to get it out of the way before any kind of 1.0 release is on the horizon.

molpopgen avatar Aug 03 '23 20:08 molpopgen

I might just go ahead and do this, we've got a bunch of PRs in flight and #2811 doesn't look like a quick fix. Any objections @benjeffery?

jeromekelleher avatar Aug 04 '23 08:08 jeromekelleher

#2811 needs to be done for lshmm anyway. So expediting this won't help. I should get #2811done today.

benjeffery avatar Aug 04 '23 08:08 benjeffery

Ah right, let's backburner so

jeromekelleher avatar Aug 04 '23 09:08 jeromekelleher

Fixed in #3138

benjeffery avatar Apr 30 '25 15:04 benjeffery