tskit icon indicating copy to clipboard operation
tskit copied to clipboard

Support for python 3.11

Open benjeffery opened this issue 2 years ago • 5 comments

3.11 betas are coming out, with this version having some breakage in the C API.

benjeffery avatar May 10 '22 09:05 benjeffery

I've had a go at this but can't get numpy to build due to https://github.com/numpy/numpy/issues/21422 so will wait for things to settle down.

benjeffery avatar May 10 '22 09:05 benjeffery

Have you some pointers to what we can expect in terms of C API breakage @benjeffery? Nice to know what's coming up.

jeromekelleher avatar May 10 '22 10:05 jeromekelleher

The good news is "CPython 3.11 is on average 25% faster than CPython 3.10 when measured with the pyperformance benchmark suite"!!

The C API changes are at https://docs.python.org/3.11/whatsnew/3.11.html#id6 None of it looks too bad.

benjeffery avatar May 10 '22 10:05 benjeffery

None of it obviously affects us from a quick glance, so hopefully we'll get through without changes :crossed_fingers:

jeromekelleher avatar May 10 '22 10:05 jeromekelleher

3.11 is released this month, so we should have another look at this.

benjeffery avatar Oct 05 '22 12:10 benjeffery

Bringing this forward to the next release milestone.

benjeffery avatar Oct 31 '22 11:10 benjeffery

Already have conda builds on conda-forge btw, e.g.: https://anaconda.org/conda-forge/tskit/files

jeromekelleher avatar Oct 31 '22 11:10 jeromekelleher

Already have conda builds on conda-forge btw, e.g.: https://anaconda.org/conda-forge/tskit/files

Yeah, seeing that made me bump this up!

benjeffery avatar Oct 31 '22 11:10 benjeffery

So the sticking point is that lshmm has numba as a dependency. I suggest we skip the tests that need it when running under py3.11.

benjeffery avatar Nov 01 '22 14:11 benjeffery