tskit icon indicating copy to clipboard operation
tskit copied to clipboard

Flesh out metadata doc schema example

Open hyanwong opened this issue 2 years ago • 9 comments

As discussed with @benjeffery

hyanwong avatar Mar 07 '22 16:03 hyanwong

Codecov Report

Merging #2146 (bb2ebf4) into main (ab5ef8f) will increase coverage by 3.37%. The diff coverage is n/a.

:exclamation: Current head bb2ebf4 differs from pull request most recent head 8362d07. Consider uploading reports for the commit 8362d07 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
+ Coverage   89.96%   93.33%   +3.37%     
==========================================
  Files          30       27       -3     
  Lines       29274    25538    -3736     
  Branches     5706     1163    -4543     
==========================================
- Hits        26335    23835    -2500     
- Misses       1669     1673       +4     
+ Partials     1270       30    -1240     
Flag Coverage Δ
c-tests 92.26% <ø> (+5.76%) :arrow_up:
lwt-tests 89.05% <ø> (+8.91%) :arrow_up:
python-c-tests 72.09% <ø> (+4.97%) :arrow_up:
python-tests 98.89% <ø> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab5ef8f...8362d07. Read the comment docs.

codecov[bot] avatar Mar 07 '22 16:03 codecov[bot]

Thanks @hyanwong, looks good modulo JK's comments. One more detail i should comment on - additionalProperties is optional here as it will be added to the schema for you if you use struct. The same thing is happening with required which is being set on the location object in this case.

benjeffery avatar Mar 08 '22 13:03 benjeffery

OK, changed to height and age. I left a default for both there, as this is not an obvious thing to be able to do, so having an example is helpful, I think, even though the two values are basically independent.

hyanwong avatar Mar 08 '22 16:03 hyanwong

This is now ready for merging, IMO, @benjeffery

hyanwong avatar Jul 25 '23 20:07 hyanwong

@mergifyio rebase

benjeffery avatar Jul 26 '23 12:07 benjeffery

rebase

✅ Nothing to do for rebase action

mergify[bot] avatar Jul 26 '23 12:07 mergify[bot]

Yeesh 32bit tests are failing hard. Will investigate.

benjeffery avatar Jul 26 '23 12:07 benjeffery

@mergifyio rebase

benjeffery avatar Sep 21 '23 14:09 benjeffery

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Sep 21 '23 14:09 mergify[bot]