tskit icon indicating copy to clipboard operation
tskit copied to clipboard

Sorting produces invalid mutation order

Open benjeffery opened this issue 4 years ago • 2 comments

Adding

tables1.tree_sequence()
tables2.tree_sequence()

at https://github.com/tskit-dev/tskit/blob/main/python/tests/test_tables.py#L1409 causes: _tskit.LibraryError: Parent mutation ID must be < current ID

benjeffery avatar Mar 01 '21 14:03 benjeffery

I think the problem isn't so much "produces" but "doesn't fix" (as in #1197). So, arguably, this isn't a bug but an enhancement (unless there's actually some tables that sort breaks). But I agree, it's an enhancement that we should do.

petrelharp avatar Mar 01 '21 14:03 petrelharp

Adding this to 1.0 for now, but can probably bump if we don't decide to fix the mutation ordering for that.

jeromekelleher avatar Jul 23 '21 13:07 jeromekelleher

Fixed in #3257

benjeffery avatar Sep 23 '25 16:09 benjeffery