tsinfer icon indicating copy to clipboard operation
tsinfer copied to clipboard

Python 3.11 support

Open benjeffery opened this issue 2 years ago • 7 comments

benjeffery avatar May 10 '23 15:05 benjeffery

Codecov Report

Merging #822 (7af2e62) into main (e6f31ec) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files           5        5           
  Lines        1767     1767           
  Branches      310      310           
=======================================
  Hits         1538     1538           
  Misses        140      140           
  Partials       89       89           
Flag Coverage Δ
C 87.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar May 10 '23 15:05 codecov[bot]

I've removed all the version specifications and conda still isn't happy. Will need to look into why.

benjeffery avatar May 11 '23 11:05 benjeffery

Mamba gives a much better error:

Encountered problems while solving:
  - package numcodecs-0.10.0-py39h5a03fae_0 requires python >=3.9,<3.10.0a0, but none of the providers can be installed

benjeffery avatar May 11 '23 16:05 benjeffery

Ahhh. Wonder what's going on with numcodecs? They're usually pretty good for this.

jeromekelleher avatar May 11 '23 16:05 jeromekelleher

https://anaconda.org/conda-forge/numcodecs/files seems to show a py3.11 package.

benjeffery avatar May 12 '23 08:05 benjeffery

Let's just let this one sit for a bit - 3.11 packages aren't crucial for tsinfer here, right?

jeromekelleher avatar May 12 '23 09:05 jeromekelleher

I agree. 3.10 is perfectly good for the time being.

hyanwong avatar May 12 '23 09:05 hyanwong

Superseded by #936

benjeffery avatar Jul 19 '24 12:07 benjeffery