tsinfer icon indicating copy to clipboard operation
tsinfer copied to clipboard

Change SgkitSampleData to accept a path or store.

Open benjeffery opened this issue 2 years ago • 2 comments
trafficstars

The API for this currently only accepts a path. It would be better if it accepted either a path or a zarr store as an argument. For example, allowing the user to pass in a zarr store would make it easier to use the SgkitSampleData class with zarr data that has been stored in memory or in some other non-file-based storage system.

benjeffery avatar Dec 07 '22 00:12 benjeffery

Could also directly take an sgkit or xarray dataset?

benjeffery avatar Dec 07 '22 00:12 benjeffery

Seems reasonable - I figure there'll be a bunch of QC steps first on the sgkit dataset before passing in, so users will be aware of sgkit much more than zarr.

jeromekelleher avatar Dec 07 '22 09:12 jeromekelleher

Fixed in 788d4dfdd09c3f552c8b5e17b67218245f4cf46f

hyanwong avatar Sep 07 '24 07:09 hyanwong