msprime icon indicating copy to clipboard operation
msprime copied to clipboard

Factor out distributed SMC logic

Open jeromekelleher opened this issue 1 year ago • 1 comments

Bring SMC k logic together in one place as part of #2294

jeromekelleher avatar Aug 02 '24 11:08 jeromekelleher

Codecov Report

Attention: Patch coverage is 83.59375% with 21 lines in your changes missing coverage. Please review.

Project coverage is 91.13%. Comparing base (8d65577) to head (5a06136).

Files with missing lines Patch % Lines
lib/msprime.c 83.59% 12 Missing and 9 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2303      +/-   ##
==========================================
+ Coverage   90.85%   91.13%   +0.28%     
==========================================
  Files          20       20              
  Lines       11993    11868     -125     
  Branches     2330     2296      -34     
==========================================
- Hits        10896    10816      -80     
+ Misses        606      577      -29     
+ Partials      491      475      -16     
Flag Coverage Δ
C 91.13% <83.59%> (+0.28%) :arrow_up:
python 98.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 02 '24 11:08 codecov[bot]

I'm going to merge this as it should be significant improvement in terms of code readability, and I think it also fixes a few memory leaks and performance issues. I'll follow up with issues for what remains in order to release the SMC(k) code.

jeromekelleher avatar Jul 23 '25 15:07 jeromekelleher