msprime icon indicating copy to clipboard operation
msprime copied to clipboard

Support numpy >= 2, drop Python 3.8

Open jeromekelleher opened this issue 1 year ago • 2 comments

Also add support for Python 3.12

jeromekelleher avatar Jun 20 '24 10:06 jeromekelleher

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.09%. Comparing base (cbb5db3) to head (28bae68).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
- Coverage   98.70%   91.09%   -7.62%     
==========================================
  Files          11       20       +9     
  Lines        4029    11918    +7889     
  Branches      908     2433    +1525     
==========================================
+ Hits         3977    10857    +6880     
- Misses         28      581     +553     
- Partials       24      480     +456     
Flag Coverage Δ
C 91.09% <ø> (?)
python 98.70% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 20 '24 10:06 codecov[bot]

OK, looks like this mostly just works. We're successfully compiling against numpy 2.0, and running tests against numpy 1.x. We can't really test against numpy 2.0 at runtime until there's a tskit package.

Note the last commit isn't doing what it should here because we're pulling in multiple versions of numpy, and a 1.x version is coming from pip for some reason. I think we should try to reduce the number of packages coming from pip here, hopefully most of what we need is on conda-forge now.

Going to park this until a tskit package is available.

jeromekelleher avatar Jun 20 '24 11:06 jeromekelleher