msprime icon indicating copy to clipboard operation
msprime copied to clipboard

update SLiM script for verification.py

Open GertjanBisschop opened this issue 2 years ago • 3 comments

The current SLiM scripts in verification.py throw up a few errors when run with SLiM 4.0 (default installed version is the latest version of SLiM). For example, the concept of time/generations has been modified slightly, sim.generation can no longer be called to track time.

The version of SLiM used for statistical tests needs to specified explicitly and the scripts require some minor tweaks if we go with version 4.

GertjanBisschop avatar Nov 17 '22 14:11 GertjanBisschop

There's a makefile to download and compile SLiM, so perhaps we should just stick a particular version on that download (something < 4) and make sure that the verification.py will always use that?

jeromekelleher avatar Nov 18 '22 09:11 jeromekelleher

Yup. Just for completeness. Had a little look, the actual modifications are minor. Explicitly add 1 early() to the event populating the simulation. And replace sim.generation with sim.cycle.

GertjanBisschop avatar Nov 18 '22 09:11 GertjanBisschop

Great, thanks. I don't mind which direction we go.

jeromekelleher avatar Nov 18 '22 12:11 jeromekelleher

Solved in #2315 .

GertjanBisschop avatar Aug 07 '24 17:08 GertjanBisschop