msprime icon indicating copy to clipboard operation
msprime copied to clipboard

coalescent_rate_trajectory and friends assumes diploidy

Open petrelharp opened this issue 2 years ago • 1 comments

As pointed out in #1761, these functions assume diploidy. Fixing this would just require adding a ploidy argument that replaces the 2 right here.

petrelharp avatar Jul 16 '21 05:07 petrelharp

My take is that this is an enhancement, since ploidy=2 is the default elsewhere, so adding a ploidy argument is a strictly compatible change.

If someone would like to take this on, I think the main work would be validating the output for different ploidy levels, making sure to test for things population size changes as shown in #1761.

jeromekelleher avatar Jul 16 '21 08:07 jeromekelleher