Thomas Sibley

Results 339 comments of Thomas Sibley

Stepping back a bit here, what's the goal of using GitHub Releases? Is it primarily to 1. Disseminate release _information/announcements_, or 2. Distribute release _artifacts_? If (1), great. This makes...

Looking at Auspice's use of GitHub Releases, it appears that the only release assets are source code snapshots, not NPM package artifacts. Is this the same use we'd expect with...

Late to the party, but I concur with the analysis and comments above, particularly @victorlin's rationale in https://github.com/nextstrain/augur/issues/920#issuecomment-1125408882. While I don't think it's necessarily worth our time, I think an...

> The only concern would be if anyone is leveraging the Python parser for a non-tab-delimited file (e.g. `metadata.csv`). This would be a breaking change. I'm not sure if this...

Since these were never used, we can drop these from the schema without any worry about a new version or anything.

To clarify, I'm not sure it's settled that the "[Python Development API](https://docs.nextstrain.org/projects/augur/en/stable/api/api.html)" section of docs corresponds to what we consider to be Augur's public Python API. What's in and out...

I used [another GitHub search](https://cs.github.com/?scopeName=All+repos&scope=&q=%2Fimport%5Cs%2Baugur%7Cfrom%5Cs%2Baugur.*%3F%5Cs%2Bimport%2F+%28path%3A*.py+OR+path%3A*.smk+OR+path%3ASnakefile%29#) to look more widely and then quickly tallied up the results: |symbol |count |percent |histogram | |-------------------------------------------------|------:|--------:|----------------------------------------------------| |augur\.\_\_version\_\_\.\_\_version\_\_ |2 |1\.44 |\*\* | |augur\.align\.read\_sequences |2 |1\.44...

My 2¢—others will have a much better sense of what's useful in actual practice—is that it'd be ok to ditch the additional complexity of partial ambiguity and just allow full...

> …but I expect that to be a small straightforward change. Untested, but here are two ways to make that change. Smallest diff: ```diff diff --git a/augur/__init__.py b/augur/__init__.py index 31ee6826..a69dcf44...