Thomas Sibley

Results 339 comments of Thomas Sibley

(Also, I see now that several of the things I suggested on our call today were previously proposed here as well by @joverlee521 and @jameshadfield, but I hadn't caught up...

Yes, Heroku manages the deploy of the review apps, but I thought they waited for GitHub CI to pass before deploying? Or am I wrong?

Ahh, they don't currently but maybe will if we tick this ticky box? (or is that only for Heroku CI?) ![image](https://github.com/nextstrain/nextstrain.org/assets/79913/003e351e-ae27-4562-8d7f-5a5362a77687)

Hrumph. ![image](https://github.com/nextstrain/nextstrain.org/assets/79913/b26a0922-df33-45a6-bd7d-b940fa9a7594)

[Redemption](https://devcenter.heroku.com/articles/github-integration-review-apps#review-apps-and-ci)? ![image](https://github.com/nextstrain/nextstrain.org/assets/79913/99815faf-c098-46fa-9a76-4c37b5c2de48)

> how would we configure the review app build to include the locally generated index? Or do you mean to upload a temp index to S3 that gets used by...

@schneid44 Hi! Thanks for your interest in contributing. I don't think this is the best issue to work on as it's still uncertain whether we want to make any changes...

FWIW, I think this is likely to be subsumed by bigger improvements proposed in https://github.com/nextstrain/nextstrain.org/issues/511 instead.

@eharkins That all makes sense. I think it's a fine initial foray in the direction we want to go! On the face of it, [S3 inventories](https://docs.aws.amazon.com/AmazonS3/latest/userguide/storage-inventory.html) might be a useful...

A workaround already exists via double-encoding, e.g. https://nextstrain.org/fetch/data.clades.nextstrain.org/datasets/flu_h3n2_ha/references/EPI1857216/versions/2023-04-02T12%253a00%253a00Z/files/tree.json However, Auspice (I believe) updates the URL after load and ends up only singly-encoding colons so the displayed URL isn't usable as...