Tianshu Wang

Results 101 comments of Tianshu Wang

Hi, this modification was introduced in this https://github.com/Lightning-AI/lightning/pull/12604#issuecomment-1094844274, and I have also discussed the modification aspect of combining with third-party loggers at https://github.com/Lightning-AI/lightning/issues/12028#issuecomment-1088325894, and currently PL logger is not perfect.

Hi, as the submitter of that PR, I'm sorry for the inconvenience, the intention was to fix the name property of WandbLogger. The reason for setting wandb `run_name` to `name...

here is toy code for reference ```python import git import json import os import socket def save_git_info(folder_path: str) -> None: repo = git.Repo(search_parent_directories=True) repo_infos = { "repo_id": str(repo), "repo_sha": str(repo.head.object.hexsha),...

@epwalsh I would be glad to make a pull request. I will take a look when I have time.

@epwalsh Awesome, I think it's a more common solution.

@epwalsh I would love to, but I cannot promise.

@epwalsh Sorry, I probably won't think about submitting a PR. hope someone is interested

@Shreyz-max No problem of course.

> Is this still the case for others and on Big Sur? Yes, macOS Big Sur 11.4.

I got this same error both on Keyboard Maestro and Hammerspoon, use applescript fix temporarily: ```lua hs.osascript.applescript("tell application \"System Events\" to key code 123 using control down") ```