vegeta icon indicating copy to clipboard operation
vegeta copied to clipboard

go 1.18 compatibility: import latest `github.com/streadway/quantile` commit

Open wolfwfr opened this issue 2 years ago • 1 comments

Proposal

I would like to ask to update this repository by importing the latest commit of the github.com/streadway/quantile dependency.

Currently, trying to import the tsenart/vegeta repository into a go v1.18 project, I get the following error on running go mod tidy:

bitbucket.org/innius/api/test/throttling tested by
	bitbucket.org/innius/api/test/throttling.test imports
	github.com/tsenart/vegeta/v12/lib tested by
	github.com/tsenart/vegeta/v12/lib.test imports
	github.com/streadway/quantile tested by
	github.com/streadway/quantile.test imports
	.: "." is relative, but relative import paths are not supported in module mode

This relative import statement in github.com/streadway/quantile appears to have been removed in their latest commit.

Background

Using go v1.18 and importing this repo yields errors from go mod commands and is preventing successful builds.

Workarounds

revert to older version of go.

wolfwfr avatar May 13 '22 09:05 wolfwfr

Is there any updates on this issue?

abdukhashimov avatar Aug 18 '22 06:08 abdukhashimov