Tres Seaver
Tres Seaver
_From @jamadden on August 22, 2016 17:57_ Cross-ref with #20 for zc.zodbdgc; using the right GC strategy for a multi-database is critical.
@bmenasha Thanks for the report. PR googleapis/google-cloud-python#5364 made a change such that shared types (such as `google.longrunning.operation_pb2.Operation` no longer have their modules overwritten. I argued (in issue googleapis/google-cloud-python#4715) that overwriting...
@bmenasha I can see the "empty" types you reference [here](http://google-cloud-python.readthedocs.io/en/latest/monitoring/gapic/v3/types.html#google.cloud.monitoring_v3.types.MessageOptions). @theacodes Is this an issue we should be solving in the codegen side?
/cc @lukesneeringer Can you suggest a way we could get docs generating properly for the "common" API proto messages?
Not only is the testcase triplicated, so are the `dataset_path` and `parse_dataset_path` methods (see https://github.com/googleapis/python-aiplatform/issues/897): the generated is capable of [reordering them](https://github.com/googleapis/python-aiplatform/pull/895), which is a breaking change.
> I think whether or not this bites you depends on many factors (Python version? Pip version?). Or setuptools version: setuptools and pip have never worked and played well together...
Can you add a test and an entry in `CHANGES.rst`?
I'm not really up on the guts of the '+=' implementation, but the test looks like it illustrates the problem clearly, and I can kind of see how your fix...
@djay OK by me to merge.