Till Schneidereit
Till Schneidereit
I haven't done a real code review, and certainly shouldn't be the one to sign off on all implementation aspects. With that said: this looks great, and I'm very excited...
> * No support for `SPIN_PROFILE` environment variable > * No support for selecting the `debug` profile with `--debug` > * No aliasing of `release` to the anonymous profile >...
> And then it sorta kinda made sense to me that a profile might involve only overriding a dependency or EV, and not change the binary at all. Yeah, I...
@vbmade2000 that'd be fantastic!
@vbmade2000 not quite, though correct in most cases. Number of invocations is the number of incoming http requests. We might instantiate multiple components to serve a request, though for now...
That was unclear indeed. I care about the binary in particular, but I guess I mean both. This makes me realize that there's a more general way to think about...
There is also the option of trying to get the language toolchain to work and provide a usable `cabi_realloc`. That's not something that fundamentally can't be done for managed language...
As [mentioned](https://github.com/CraneStation/wasmtime/pull/235#issuecomment-518610167) in the linked Wasmtime PR, I don't think we can require either case-sensitivity *or* case-insensitivity, unfortunately. @programmerjake [mentioned](https://github.com/CraneStation/wasmtime/pull/235#issuecomment-518897502) a potential way to at least help with portability issues...
It's possible that this can be relaxed, and if the current requirements create undue implementation burdens for anything that is *not* fetch, then that might be the right call, too....
I agree that we should unblock gRPC over wasi-http. For the specific way of going about it, I wonder if we might be able to get away with something slightly...