RefactoringMiner icon indicating copy to clipboard operation
RefactoringMiner copied to clipboard

"Next" should follow the order of GitHub

Open koppor opened this issue 5 months ago • 1 comments

As workaround for missing GitHub review functionality, I open BOTH GitHub Diff and Refactoring Miner

Example: https://github.com/JabRef/jabref/pull/13554 (commit https://github.com/JabRef/jabref/pull/13554/commits/561acce7864fba4023645d1d14f1ae9ebdf7bc06)

I am on "JabRefGUI.java"

Image

"JabRefGuiStateManager" is a new file.

Deteced as refactoring (which is great)

Image

Gues which file is displayed by GitHub after "JabRefGUI.java" - and which file comes when clicking on "Next" on Refactoring Miner?

GitHub shows "JabRefGuiStateManager.java", whereas Refactoring Miner shows "LibraryTab".

koppor avatar Jul 23 '25 10:07 koppor

@koppor

There are two sub-issues related to that.

  1. We display all deleted and added files after the modified ones.
  2. We change the order we process the files based on their dependencies to facilitate refactoring detection. This also changes the order the files appear in the Overview page.

The reason we change the original order of the files (as fetched from GitHub) is in order to process first the files that include references to APIs in the other files of the PR. By utilizing references (i.e., method calls) being updated (e.g., renamed), we can improve the accuracy of the tool in matching the corresponding method declarations.

I can only fix sub-issue 2 (displaying the modified files in the order GitHub shows them, i.e., lexicographical ordering), but I cannot fix sub-issue 1 based on the current design of the UI.

tsantalis avatar Jul 31 '25 08:07 tsantalis