RefactoringMiner icon indicating copy to clipboard operation
RefactoringMiner copied to clipboard

Added Java comment should be shown

Open koppor opened this issue 1 year ago • 1 comments

Context: https://github.com/JabRef/jabref/pull/11399

GitHub:

image

RefactoringMiner:

image

koppor avatar Jun 20 '24 11:06 koppor

@koppor Thank you for reporting this issue.

This is actually an inline comment, not Javadoc.

The reason I make this distinction is because the Eclipse JDT Parser we use, represent Javadoc as AST nodes, but inline comments are not represented as AST nodes. This makes it impossible for us to show any changes for inline comments.

I will discuss with @pouryafard75 if there is any way to solve this issue.

tsantalis avatar Jun 20 '24 19:06 tsantalis

@koppor @pouryafard75 Once this PR get merged, we will be able to support inline comment diff.

tsantalis avatar Aug 30 '24 17:08 tsantalis

@pouryafard75 PR merged.

tsantalis avatar Sep 09 '24 19:09 tsantalis

@tsantalis I beleive they have a CI pipeline for publishing to maven central. So as soon as new release get published in maven, we migrate to it. If they dont publish a new release, I will find a workaround for it.

pouryafard75 avatar Sep 12 '24 20:09 pouryafard75

image

@koppor @tsantalis

pouryafard75 avatar Oct 03 '24 04:10 pouryafard75

@koppor Comment diff is still under development. If you see anything strange related to comments, please report it to us. I will close this issue, as it is fixed. We have created a new issue #785 related to comments.

tsantalis avatar Oct 03 '24 12:10 tsantalis