Tom Ashford
Tom Ashford
> > To get unit tests to pass you'll need to remove the failing tests related to MAX_ZONES_ALL_TRACKS, and to make this equivalent C++, the incrementing `totalZones` variable in C++...
Oh heads up, that failing E2E test is just a flaky test we haven't fixed yet, can ignore. The linter thing needs addressing though, `nx lint formats-zone` should do it...
> I was struggling to get the tests to pass locally and I think it is because counting the regions in the `validateZone` function was causing overcounts. I added a...
Yeah. Staging deploys don't cost us anything and I'd much rather we run these jobs when not necessary, than fail to run them when we should. We could exclude other...
Waiting for Nick to check this out, might take a bit, but this isn't high priority.
> looks like adding `"downlevelIteration": true,` would get rid of intellisense yelling about iterators > > Property 'toArray' does not exist on type 'IterableIterator'.ts(2339) Where are you seeing this? I...
With `strict: null` in root tsconfig? I can't replicate. and don't understand why downlevelIteration would be required when we're targeting ESNext. Do you want to put a branch where the...
Agreed, makes C++ easier as well.
Might find time to review at some point but probably not until all 0.10.0 work is done on my end, which will probs come down to the wire
The reason for this is that with Cloudflare R2 we pay per file served, but don't pay for egress. So it costs twice as much to serve multiple versions of...