Tom Ashford
Tom Ashford
Aaaalmost, just you've still got a fixup commit. If you just reorder the commit with the UI stuff and the commit with the assemblyversion stuff, you can easily amend any...
Yeah looks good. And no problem, we're pretty exacting with structuring commits so naturally we're happy to help people struggling with it. Git is a hassle to learn at first,...
Okay done, though haven't tested. Please take a look and make sure everything works and makes sense to you, then fixup into your commit! Spent a while trying to do...
Oh gotcha, both those fixes make sense. We're probably about ready to merge but going to give BIRD the opportunity to look at this, and not sure if we'll merge...
Just thinking about this a little today, might be a better approach to pull the updating logic out to a separate executable so we can copy and replace stuff easier....
Discussed this a bit yesterday and keen to avoid the shell scripts. Most of the code here we'll still use, but we'll probably pull some of it out to separate...
Closing these since https://github.com/momentum-mod/lumper/pull/78 supersedes it. Kept a lot of your code @dbampersand, mainly just changed how we handle the downloaded zip so we have to do fewer shell commands....
Yeah, just pinging github API should work fine. Probably most appropriate in a dedicated service, like BspService and PageService. You can access the Main Window via Program.Desktop and display a...
Assuming we're not actually any kind of installer and just linking the page, this is a relatively small issue, only real work is figuring out the github API endpoint, probably...
On mobile which doesn't seem to support adding new labels, but this is a Good First Issue!