norfair icon indicating copy to clipboard operation
norfair copied to clipboard

Set draw_labels to false by default

Open aguscas opened this issue 1 year ago • 2 comments
trafficstars

The default value for draw_labels was not the same in draw_boxes and draw_points. For consistency, I think it would be better to have the same default value

aguscas avatar Feb 23 '24 13:02 aguscas

Does this affect any demo? maybe the videos look different now if they were relying on the default argument

javiber avatar Feb 26 '24 18:02 javiber

Does this affect any demo? maybe the videos look different now if they were relying on the default argument

I would argue that doing this make the demos even more consistent with the videos we show in their README. As you can see in the yolov7 demo when we use this function we use the default value, but in the video in the README there is no label. That is because the video was generated with the old drawing functions, and when we updated the drawing functions we forgot to pass the argument to not draw the labels.

aguscas avatar Feb 26 '24 19:02 aguscas