norfair icon indicating copy to clipboard operation
norfair copied to clipboard

Dependency Issue

Open mgmalana opened this issue 2 years ago • 4 comments

I'm using Norfair and another library. However, I'm getting a version conflict for rich.

Is it possible to change the dependency of norfair to be able to use higher version of rich? I'm using poetry to install norfair and I'm getting a "SolveProblemError Because norfair (0.4.0) depends on rich (>=9.10.0,<10.0.0)". I need to use at least version 11.2.0.

I can force install higher version of rich using pip but I think it would be cleaner if the dependencies are clear. Norfair seems to work fine even with higher version of rich.,

mgmalana avatar Apr 07 '22 07:04 mgmalana

Hi, thanks for the feedback! We're experiencing some issues with our installation flow in general, so this feedback is really useful for us to consider this case in our fixes. Would you mind sharing which other dependency is having issues with rich so we can test our fixes?

joaqo avatar Apr 08 '22 18:04 joaqo

@joaqo thank you for your reply! I'm trying to use BentoML library. It needs rich >=11.2.0 or else the library will raise an error as described here issue. Thank you very much for your work in norfair!

mgmalana avatar Apr 11 '22 06:04 mgmalana

Awesome, thanks, we'll look into it!

joaqo avatar Apr 11 '22 17:04 joaqo

We're experiencing a similar issue when trying to use norfair coupled with lightning. While norfair implicitly depends on typing-extensions(>-3.7.4,<4.0.0) due to a direct dependency on rich(>=9.10.0, <10.0.0), lightning has a direct dependency on typing-extensions(>=4.0.0, <4.3.1) [reference]. Note that lightning also places a direct constraint on rich [reference].

For the time being, we have resorted to using an older version of pip with the --no-deps flag to force the installation of the seemingly incompatible packages.

It would be very useful if you bumpednorfair's rich version.

sebastian-correa avatar Aug 10 '22 13:08 sebastian-correa

Please may this be prioritized. This is a major block for use with other projects.

nmichlo avatar Aug 31 '22 22:08 nmichlo

Hey @nmichlo We are working on this at the moment. I will make a PR as soon as poetry finishes locking the dependencies... that might take a while

javiber avatar Sep 01 '22 16:09 javiber

#160 is merged, so this issue is finally solved!

For now and before we do the next release on PyPI, please install Norfair from GitHub master branch.

dekked avatar Sep 02 '22 20:09 dekked