metrics-mvp icon indicating copy to clipboard operation
metrics-mvp copied to clipboard

Improvements to journey info table

Open hathix opened this issue 5 years ago • 4 comments

I was viewing this route comparison:

image

Thoughts:

  • Isn't it a bad thing for on-time rate to go down 20%? In that case, shouldn't the text be orange/red instead of green?
  • The completed trips metric isn't all that useful, since the date ranges are different lengths. "Completed trips per day" for multiple-day routes would be ideal.
  • For Median Wait Time, I'd rather see it called "even" rather than not having a label at all.

hathix avatar Apr 30 '20 02:04 hathix

I'm starting to work on this in the route-table branch. Others can run with this if I don't finish it quickly.

hathix avatar Apr 30 '20 02:04 hathix

Update -- no need for "even" since nothing is truly equal. In my branch I'm just going to make it show "<1" if the difference is very small; currently that code path doesn't trigger.

But I did fix the on-time rate coloring issue. The completed trips metric might be big enough to deserve its own PR.

hathix avatar Apr 30 '20 03:04 hathix

https://github.com/trynmaps/metrics-mvp/tree/route-table

hathix avatar Apr 30 '20 03:04 hathix

The completed trips bit is hard. You'd have to do it per hour for it to really be valuable.

hathix avatar May 07 '20 02:05 hathix