metrics-mvp icon indicating copy to clipboard operation
metrics-mvp copied to clipboard

adding share button to share route info to different social media platforms

Open ckrajewski opened this issue 5 years ago • 8 comments

Fixes #517

Proposed changes

Add a share button using Material UI to show a drop down of platforms to share routes to

Screenshot

image

ckrajewski avatar Feb 20 '20 05:02 ckrajewski

Need feedback on button color - should not be blue obviously

ckrajewski avatar Feb 20 '20 05:02 ckrajewski

It would be nice to have something like the "English" button on the Material UI website (white with no background and a caret pointing down):

Screen Shot 2020-02-19 at 9 23 20 PM

hathix avatar Feb 20 '20 05:02 hathix

Kinda like this: https://material-ui.com/components/app-bar/#app-bar-with-menu

hathix avatar Feb 20 '20 05:02 hathix

I'd suggest using the typical share icons instead of the word "share"

https://material-ui.com/components/material-icons/

akgupta89 avatar Feb 20 '20 05:02 akgupta89

Feel free to take a look at PR Currently looking ar using Material UI icons instead on the ones provided from https://www.npmjs.com/package/react-share Though I am getting an error when trying to import Material UI icons

image

ckrajewski avatar Mar 05 '20 04:03 ckrajewski

Chris, it looks like you might have to change some code now that the UI has been changed a lot. The share button will probably have to go in the white bar on the route screen:

image

hathix avatar Apr 16 '20 02:04 hathix

note from our call: put the share button in the white header bar on the routes page (to the right of the date/time/route selectors). It doesn't make sense to add the share button to the header bar, because it doesn't make sense adding it to the blue bar (since that would imply that sharing is available on the entire app... and it makes less sense on the about page or the homepage).

hathix avatar Apr 23 '20 01:04 hathix

I'll review this.

hathix avatar May 28 '20 01:05 hathix