udp-discovery-cpp icon indicating copy to clipboard operation
udp-discovery-cpp copied to clipboard

Make peerId to use UUID version 4

Open truvorskameikin opened this issue 3 years ago • 0 comments

Now we use uint32_t as the peerId.

Also we use very strange logic to filter and compare discovered peers (see Same method at https://github.com/truvorskameikin/udp-discovery-cpp/blob/master/udp_discovery_peer.hpp#L87) - it uses peer address and maybe peer port. But if we implement sending packets to all the interfaces then this logic will just break showing multiple peers that are just single peer. Let's remove this comparison but rely on comparing peerIds.

This change will require protocol update.

truvorskameikin avatar Jun 22 '21 10:06 truvorskameikin