wallet-core icon indicating copy to clipboard operation
wallet-core copied to clipboard
verified publisher icon trustwallet

JVM memory leak fix

Open vcoolish opened this issue 1 year ago • 2 comments

Fixes #4021

Changes:

  • Created phantom reference registry with one thread which cleans up objects when needed.
  • Also added instrumentation testing support for kotlin target, for KMP testing purposes.

vcoolish avatar Oct 17 '24 19:10 vcoolish

Hi @vcoolish, could you explain a little bit why the old code doesn't work?

10gic avatar Oct 18 '24 06:10 10gic

Hi @vcoolish, could you explain a little bit why the old code doesn't work?

because it did register, but never did clean up. so it was a useless implementation of reference registry without actual logic inside to clean up references, only to track them.

vcoolish avatar Oct 18 '24 14:10 vcoolish