wallet-core icon indicating copy to clipboard operation
wallet-core copied to clipboard
verified publisher icon trustwallet

[Dev/UnderAudit]: Dev<->Master

Open satoshiotomakan opened this issue 1 year ago • 1 comments

Description

dev branch contains important fixes of Kotlin Multiplatform memory leaks.

How to test

Integrate pre-release artifacts into a KMP sample/app and run it with a memory profiler.

Types of changes

See the changed files

Checklist

  • [x] Create pull request as draft initially, unless its complete.
  • [x] Add tests to cover changes as needed.
  • [x] Update documentation as needed.
  • [x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • [x] I have read the guidelines for adding a new blockchain.

satoshiotomakan avatar Oct 01 '24 12:10 satoshiotomakan

Thank you very much for auditing. Could you let me know how long the auditing will take?

10gic avatar Oct 09 '24 13:10 10gic

Hi @satoshiotomakan, I hope you're ready for some holiday magic. Is there any chance we could sprinkle some Christmas cheer by merging this PR into the master branch before Christmas Day? It would be a fantastic gift for our project!

10gic avatar Nov 28 '24 17:11 10gic

Hey @10gic, I would merge right now, but I have to wait for the security audit. Requested one more round one week ago, really hope to give an update ASAP. If no update next week, I'll push them so to merge it before Christmas Day :facepunch: Wish we all can sleep well soon :)

satoshiotomakan avatar Nov 28 '24 17:11 satoshiotomakan