wallet-core icon indicating copy to clipboard operation
wallet-core copied to clipboard

Fixed protobuf-plugin for newer versions of protobuf

Open EduMenges opened this issue 1 year ago • 1 comments

Current CMake for protobuf-plugin uses old paradigms that no longer work in newer versions of protobuf since they made the absl dependency public. This patch addresses this issue as well as bumping CMake's version to 3.5, since older versions are deprecated.

EduMenges avatar Jun 20 '24 13:06 EduMenges

Ideally, this fix (using protobuf::libprotobuf instead of raw library) should also be applied to the main CMakeLists.txt file but that would require a rewrite on how wallet-core builds protobuf. Really, compiling protobuf manually, source by source instead of using add_subdirectory is just wrong.

EduMenges avatar Jun 20 '24 14:06 EduMenges

Hi @EduMenges, thank you for opening the PR! Could you please fix finding Protobuf library for Android and Kotlin targets?

satoshiotomakan avatar Aug 07 '24 10:08 satoshiotomakan

Hi @EduMenges, please let me know once the PR is ready for the next review

satoshiotomakan avatar Aug 09 '24 15:08 satoshiotomakan

@satoshiotomakan Hi, I think you can run the CI now 💋

EduMenges avatar Aug 09 '24 16:08 EduMenges

@satoshiotomakan I fixed it again, please run the CI 🙏🏻

EduMenges avatar Aug 14 '24 19:08 EduMenges