wallet-core icon indicating copy to clipboard operation
wallet-core copied to clipboard

[Breaking Change] Add Ripple token and NFT support

Open joterway opened this issue 1 year ago • 4 comments

Description

Added support for issued tokens and NFTs for the Ripple blockchain.

How to test

Unit tests were added for the Ripple blockchain. Transactions were generated using xrpl-py and the serialized result were added as expected output in the unit tests with the same inputs. Links to the broadcasted transactions have been included in the unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue) fullyCanonical flag was removed as it is now deprecated and caused a mismatch with xrpl-py

  • New feature (non-breaking change which adds functionality)

Payment was extended to support issued currencies. Also added factory functions for building TrustSet, NFTokenBurn, NFTokenCreateOffer, NFTokenAcceptOffer, and NFTokenCancelOffer.

Checklist

  • [x] Create pull request as draft initially, unless its complete.
  • [x] Add tests to cover changes as needed.
  • [x] Update documentation as needed.
  • [x] If there is a related Issue, mention it in the description.

joterway avatar Oct 31 '22 22:10 joterway