wallet-core icon indicating copy to clipboard operation
wallet-core copied to clipboard

Add Everscale support

Open pashinov opened this issue 3 years ago • 7 comments

Description

Adding support for Everscale blockchain https://everscale.network/

How to test

We've written test cases in tests/Everscale folder.

Types of changes

Checklist

  • [x] Create pull request as draft initially, unless its complete.
  • [x] Add tests to cover changes as needed.
  • [x] Update documentation as needed.
  • [x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • [x] I have read the guidelines for adding a new blockchain.

pashinov avatar Jul 29 '22 16:07 pashinov

Btw there is probably a bug in Base64::decode. This encoded transaction should be 5194 bytes long, but it is decoded as 5192 bytes.

Why is it truncating last null bytes of decoded binary data?

Rexagon avatar Aug 03 '22 12:08 Rexagon

All methods were covered by tests!

pashinov avatar Aug 03 '22 18:08 pashinov

could you please merge master? we improved build time for Linux

hewigovens avatar Aug 04 '22 23:08 hewigovens

could you please merge master? we improved build time for Linux

I've already merged it but it broke tests. https://github.com/broxus/wallet-core/commit/b2c12b8e7b619460c2898f756e95972141e128b4

pashinov avatar Aug 05 '22 09:08 pashinov

could you please merge master? we improved build time for Linux

I've already merged it but it broke tests. broxus@b2c12b8

You can also invite me to the project, can fix the compilation

Milerius avatar Aug 05 '22 11:08 Milerius

could you please merge master? we improved build time for Linux

I've already merged it but it broke tests. broxus@b2c12b8

You can also invite me to the project, can fix the compilation

Access was granted

pashinov avatar Aug 05 '22 14:08 pashinov

Do we need to create online account for user to receive coins?

You just need to compute the address from pubkey. Explicit account deployment is not required, it occurs on the first outgoing transfer (init state is attached to the external message).

Rexagon avatar Aug 18 '22 08:08 Rexagon