wallet-core icon indicating copy to clipboard operation
wallet-core copied to clipboard

[Debt] Separate non-Cosmos logic from Cosmos folder/proto

Open optout21 opened this issue 3 years ago • 2 comments

Currently Cosmos proto/folder contain some chain-specific proto files and logic, for Stargate (protobuf serialization) case:

  • Terra WASM messages
  • Thorchain send (pending #2092)

This includes:

It would be good to separate these non-Cosmos, chain specific dependencies to their own folder (Terra, ...). However, this is not easy to do without much code duplication, as a big part is reused from Cosmos. Moving out messages to own proto file should be done without duplicating all Cosmos proto part. Cosmos signgin and ProtobufSerialization logic should be made extensible, with convert logic moved out in chain-specific parts, without duplicating the whole Cosmos signing logic (this would require changing the global/static methods to class members, with virtual overridable convert).

optout21 avatar Mar 23 '22 09:03 optout21

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Apr 20 '22 22:04 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar May 10 '22 22:05 github-actions[bot]