sphinx-maven-plugin icon indicating copy to clipboard operation
sphinx-maven-plugin copied to clipboard

Download binaries from remote repository (e.g. mvn central) instead of custom code in plugin

Open pvasterd opened this issue 5 years ago • 2 comments

Just tried to update to 2.9.0 of sphinx-maven-plugin (from 1.1.0.Final) and noticed that the binaries are directly retrieved from github.com.

I am running the plugin behind proxies (in corporate environment) where I don't have access github.com directly. Yes, I may be able to get this working with proxies or downloading the binaries myself and use the binaryUrl configuration setting to get this to work, but this won't be nice as I would need credentials to either go onto the internet or access these binaries in some local repository. To run this on buildservers, I would need to setup non-personal accounts (NPAs), mange its password, make sure the credentials somehow end up in the maven pom etc.

I am wondering why the plugin is not set up to use the maven mechanism itself to take care of this, so:

  • publish the binaries in mvn central
  • define architecture specific dependency per architecture/OSs (so you can define multiple if you want your maven project to support multiple architectures/OSs)
  • have the plugin still figure out what OS architecture it is running on and find the binary in the local maven repo.

Would help us a lot.

Also, I could make a PR to make this happen, if you would accept the PR.

pvasterd avatar Apr 20 '20 07:04 pvasterd

Hi! Sorry for a late reply. Yeah, I like the idea of publishing the binaries in Maven Central. I guess we'll have to update the build in https://github.com/trustin/sphinx-binary first to make this happen, though.

trustin avatar Feb 11 '21 10:02 trustin

+1

gutomaia avatar Apr 19 '23 10:04 gutomaia