Trustin Lee

Results 147 issues of Trustin Lee

From https://github.com/line/armeria/runs/2564682267?check_suite_focus=true#step:7:1444 ``` HttpServerRequestTimeoutTest > setRequestTimeoutAfterNoTimeout() FAILED java.util.concurrent.CompletionException: com.linecorp.armeria.common.stream.ClosedStreamException: received a RST_STREAM frame: INTERNAL_ERROR at java.base/java.util.concurrent.CompletableFuture.reportJoin(CompletableFuture.java:412) at java.base/java.util.concurrent.CompletableFuture.join(CompletableFuture.java:2108) at com.linecorp.armeria.common.util.EventLoopCheckingFuture.join(EventLoopCheckingFuture.java:88) at com.linecorp.armeria.server.HttpServerRequestTimeoutTest.setRequestTimeoutAfterNoTimeout(HttpServerRequestTimeoutTest.java:198) Caused by: com.linecorp.armeria.common.stream.ClosedStreamException: received a RST_STREAM frame: INTERNAL_ERROR...

cleanup

``` RefreshingAddressResolverTest > negativeTtl() FAILED org.opentest4j.AssertionFailedError: Expecting: to be equal to: but was not. at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) at com.linecorp.armeria.client.RefreshingAddressResolverTest.negativeTtl(RefreshingAddressResolverTest.java:275) ```

cleanup

``` ArmeriaReactiveWebServerFactoryTest > shouldConfigureTlsWithSelfSignedCertificate() FAILED java.util.concurrent.TimeoutException: shouldConfigureTlsWithSelfSignedCertificate() timed out after 60 seconds at org.junit.jupiter.engine.extension.TimeoutInvocation.createTimeoutException(TimeoutInvocation.java:70) at org.junit.jupiter.engine.extension.TimeoutInvocation.proceed(TimeoutInvocation.java:59) at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84) at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115) at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)...

cleanup

When a user implements a gRPC service using `AbstractUnaryGrpcService`, he or she can throw an `ArmeriaStatusException` to send an error response. However, the user can't send the error details as...

new feature

e.g. ```java Publisher reactive = ...; InputStream in = reactive.toInputStream(); // Creates a subscription. in.read(); ... ``` ```java StreamMessageWriter reactive = ,,,; OutputStream out = reactive.asOutputStream(); objectMapper.writeValue(out, myJsonObject); ```

new feature

We could provide a decorator that aborts the stream when there's not enough traffic for a certain period of time, e.g. Abort the connection if less than 64KiB was transferred...

new feature

Sometimes, a user wants to write an Armeria-level decorator (i.e. `SimpleDecoratingHttpService`) which intercepts a gRPC request and sends a pre-defined gRPC response instead of delegating to the actual `GrpcService`. This...

new feature

The leak was reported while running the tests without advanced leak reporting: ``` 02:08:31.660 [armeria-common-worker-nio-3-2] ERROR io.netty.util.ResourceLeakDetector - LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more...

defect

When a user uses an `AbstractUnaryGrpcService`, he or she uses `ServiceRequestContext.setAdditionalResponseTrailer()` to add gRPC metadata to the response. However, this doesn't always work: - When `handleMessage()` throws an exception, a...

new feature

@tommyulfsparre reported [an issue](https://github.com/netty/netty/issues/12320) in Netty, which may also be relevant to us. We should check if we're also affected by this issue.