OpenDMARC icon indicating copy to clipboard operation
OpenDMARC copied to clipboard

OPENDMARC_LIB_VERSION no longer contains version information

Open DrRemorse opened this issue 2 years ago • 1 comments

This used to contain version information:

$ grep OPENDMARC_LIB_VERSION /usr/include/opendmarc/dmarc.h #define OPENDMARC_LIB_VERSION 0x01030200

Now it contains 0x00000000. Can you check to see if perhaps a version number generator is not working?

I am currently using the following logic and hope version numbers are supported again in the future:

#if (OPENDMARC_LIB_VERSION >= 0x01040000L) || (OPENDMARC_LIB_VERSION == 0x00000000L) s = opendmarc_policy_store_dkim(dmarc, domain, selector, dkim_to_dmarc(r), comment); #else s = opendmarc_policy_store_dkim(dmarc, domain, dkim_to_dmarc(r), comment); #endif

Thank you!

DrRemorse avatar Mar 03 '23 05:03 DrRemorse

Appears this used to be set as part of the dist-hook Makefile target, but that's not getting triggered via the GitHub release process, and winds up remaining the default 0. I don't see it set in any of the 1.4 release packages on here.

kjc75 avatar Mar 03 '23 19:03 kjc75