OpenDKIM icon indicating copy to clipboard operation
OpenDKIM copied to clipboard

Typo in librbl/rbl.c fails to build with -Werror on gcc14

Open tjwoodall opened this issue 1 year ago • 3 comments

diff -ur opendkim.orig/librbl/rbl.c opendkim/librbl/rbl.c
--- opendkim.orig/librbl/rbl.c  2018-11-15 00:47:38.000000000 +0000
+++ opendkim/librbl/rbl.c       2024-08-25 12:05:44.169015382 +0000
@@ -329,7 +329,7 @@
 rbl_res_close(void *srv)
 {
 #ifdef HAVE_RES_NINIT
-       struct state *res;
+       struct __res_state *res;
 
        res = srv;

This appears to be a longstanding typo. c.f. dkim_res_close in libopendkim/dkim-dns.c

tjwoodall avatar Aug 25 '24 15:08 tjwoodall

Also rbl_res_nslist() has same type miss match in #ifdef HAVE_RES_SETSERVERS context.

futatuki avatar Aug 25 '24 15:08 futatuki

Also in int dkim_res_nslist(void *srv, const char *nslist) { in libopendkim/dkim-dns.c

tjwoodall avatar Aug 25 '24 16:08 tjwoodall

Also in int dkim_res_nslist(void *srv, const char *nslist) { in libopendkim/dkim-dns.c

Ah, I remember they were proposed to be removed in PR #99

futatuki avatar Aug 25 '24 16:08 futatuki