OpenARC icon indicating copy to clipboard operation
OpenARC copied to clipboard

OpenARC failing to sign previously ARC signed messages

Open geneshuman opened this issue 7 years ago • 7 comments

The following 2 tests of the signing ARC test suite fail:

i1_base i2_base

OpenARC seems like it categorically does not correctly sign messages that have already been signed by a previous intermediary. I haven't looked closely, but at the very least it messes up creating AMS's as it seems to strip the b= tag from the previous AMS header & canonicalizes that instead of creating a new AMS with an empty b=

geneshuman avatar Jan 24 '18 19:01 geneshuman

This now appears to work; please re-test after rebasing onto the end of the "develop" branch.

mskucherawy avatar May 04 '18 19:05 mskucherawy

i1_base: https://github.com/ValiMail/arc_test_suite/blob/master/tests/arc-draft-sign-tests.yml#L453 i2_base: https://github.com/ValiMail/arc_test_suite/blob/master/tests/arc-draft-sign-tests.yml#L516

AntiFreeze avatar May 24 '18 00:05 AntiFreeze

i am experiencing same issue - just build from "develop" branch - my server unable to sign messages that forwarded from gmail.

MechanID avatar May 31 '18 10:05 MechanID

It took me a while to find it, but I believe c01bb430d488304fd024583cca03435319e2d390 fixes this. Can someone confirm?

mskucherawy avatar Jun 18 '18 08:06 mskucherawy

Hello @mskucherawy Thanks for your response! i had tested following commits from develop branch: c01bb43 Fix AMS canonicalization. 8a5a4b0 Coding style.

and faced another issue - at gmail when i checked source - header "ARC-Authentication-Results:" doesn't start from newline - at this moment header "ARC-Authentication-Results:" added in the end of the line - "Received: from some host by some other host"

in other email providers like yahoo or AOL when i looking at source i see space before headers: ARC-Authentication-Results: ARC-Message-Signature: ARC-Seal:

And this leads that google and others ignore ARC related headers that were added by my email host.

MechanID avatar Jun 20 '18 13:06 MechanID

I think some related things were fixed in the Beta1 release, which I just cut. Could you try this again, please?

mskucherawy avatar Sep 28 '18 16:09 mskucherawy

tested today on commit 7bd568508b1d9e89627e3388ddfc767d28602e15 from develop branch, it works fine, thank you very much @mskucherawy !

MechanID avatar Jan 04 '19 10:01 MechanID