terraform-aws-logs icon indicating copy to clipboard operation
terraform-aws-logs copied to clipboard

making encryption option + allowing user to use kms key for encryption

Open MrHassanMurtaza opened this issue 3 years ago • 1 comments

This PR adds two addons to the TF module:

  • Making encryption optional
  • Allowing to use KMS key for encryption

MrHassanMurtaza avatar Nov 30 '21 20:11 MrHassanMurtaza

Truss team, any way this can be merged? :-) 🙏

ellj avatar Jan 28 '22 22:01 ellj

Thanks @MrHassanMurtaza !

Can you explain your use case for optional encryption? We treat encryption-at-rest as a requirement, so this is something we'd be hesitant to support without a specific reason.

rpdelaney avatar Sep 23 '22 15:09 rpdelaney

On the face of it, disabling encryption at rest is not a workflow we want to support. However, if you can explain your use case we will consider it. :) Thank you very much for contributing!

rpdelaney avatar Oct 14 '22 15:10 rpdelaney