react-uswds icon indicating copy to clipboard operation
react-uswds copied to clipboard

feat: Add all component prop type definitons as exports

Open RobKohr opened this issue 1 year ago • 3 comments

When creating a wrapper that extends a uswds component, it is useful to import in the Props that the wrapped component has so that the wrapped component’s prop types can be extended rather than having to copy and paste them.

To allow this, I am adding exports for all Props type definitions.

This shouldn’t have any impact on any projects that use react-uswds.

Summary

Related Issues or PRs

https://github.com/trussworks/react-uswds/issues/2667 #2728

How To Test

Nothing should change for the use of the package, but anything importing the package should also be able to import the Props type definition for any component.

RobKohr avatar Nov 20 '23 18:11 RobKohr

Thanks @RobKohr! Take a look at the existing issue for this change; there might be a few more considerations before we can call it done.

rswerve avatar Nov 20 '23 18:11 rswerve

Thanks @RobKohr! Take a look at the existing issue for this change; there might be a few more considerations before we can call it done.

@RobKohr I'd love to get this merged in the next release if you have some time to review the above. Do you need any help?

werdnanoslen avatar Jan 22 '24 22:01 werdnanoslen