Cut over to config-rs for config system
We currently have our own hierarchical config system. Works well, but extending it can be a bit tough, especially for new folks.
If we cut over to https://github.com/mehcode/config-rs, we get all of the same features we currently have and we gain a few:
- config file inheritance. Users might have their base config file, but then override it based on the environment they are building for.
- technically, in order to support this we will need to configure trunk to accept multiple values for the
--configopt.
- technically, in order to support this we will need to configure trunk to accept multiple values for the
- we can still overwrite values coming from the CLI, but we will need a little addition work for this. However, this will be dead simple.
Overall, this should greatly simplify the Trunk config system, and should reduce the barrier of entry for adding new features to Trunk which require config changes/updates.
I played with this the other day and got the TOML loaded correctly.
Not sure when I'll be able to get back to it and the code is definitely a work in progress (I still haven't gotten environment variables successfully merged with the config file), but I wanted to leave it here in case anyone else starts on it and wants something to reference.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
This issue was closed because it has been stalled for 5 days with no activity.